[v6.x backport] tools: replace assert-throw-arguments custom lint#15253
Closed
Trott wants to merge 1 commit intonodejs:v6.x-stagingfrom
Closed
[v6.x backport] tools: replace assert-throw-arguments custom lint#15253Trott wants to merge 1 commit intonodejs:v6.x-stagingfrom
Trott wants to merge 1 commit intonodejs:v6.x-stagingfrom
Conversation
The functionality of ESLint custom rule assert-throws-arguments can be replaced with no-restricted-syntax entries. PR-URL: nodejs#14547 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
The functionality of ESLint custom rule assert-throws-arguments can be replaced with no-restricted-syntax entries. Backport-PR-URL: #15253 PR-URL: #14547 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
landed in f8b85e1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14547 /cc @MylesBorins
The functionality of ESLint custom rule assert-throws-arguments can be
replaced with no-restricted-syntax entries.
PR-URL: #14547
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Timothy Gu timothygu99@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)