doc: fix links in some intra-repository docs#15675
doc: fix links in some intra-repository docs#15675vsemozhetbyt wants to merge 2 commits intonodejs:masterfrom vsemozhetbyt:doc-gh-links
Conversation
|
I do not know how to fix this link in the doc/releases.md#3-a-publicly-listed-gpg-key: https://sks-keyservers.net/i/#submit (404 Not Found) Let me know about the equivalent. |
COLLABORATOR_GUIDE.md
Outdated
There was a problem hiding this comment.
Maybe it's better to use CONTRIBUTING.md#commit-message-guidelines.
COLLABORATOR_GUIDE.md
Outdated
|
Thank you, Let's see what others think. The https://sks-keyservers.net/ itself is OK, it just https://sks-keyservers.net/i/#submit (some form?) is now 404. |
|
How http://hkps.pool.sks-keyservers.net looks is different for everybody because it's just a mirror to a pool of key servers. For me personally, just two minutes ago that URL showed "keyserver.ntzwrk.org" but now it shows "keys2.kfwebs.net". Because of that, the submission feature may not always be available on the mirror the URL currently redirects to; the anchor for the "Submit" section may certainly be different as well. I would just pick one keyserver, like the one provided by MIT or by Ubuntu/Canonical. They end up getting synced pretty soon anyway. |
|
Rebased after 9807744 |
|
@TimothyGu Can you suggest a wording with one of your links (or both)? |
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Went ahead and landed in 6be96c7. We can make further changes in a separate PR |
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: nodejs/node#15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Checklist
Affected core subsystem(s)
doc, meta