util,errors: make display of errors consistent with browsers#15765
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
util,errors: make display of errors consistent with browsers#15765Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
3455348 to
de0fc0b
Compare
In Chrome, adding or mutating properties does not change the output of `Error` objects displayed via `console.log()` etc. This change replicates that behavior in Node.js.
de0fc0b to
a59664a
Compare
Member
Author
|
#15694 landed so this is now unblocked. |
Member
Author
|
Labeled as |
Member
Author
|
I'm going to close this pull request. Firefox behaves differently than Chrome. In Firefox, if you change the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Chrome, adding or mutating properties does not change the output of
Errorobjects displayed viaconsole.log()etc. This changereplicates that behavior in Node.js.
This is blocked until #15694 lands as some of the changes depend on that PR.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util tests