test: update 'fixturesDir' refs in a test file#15824
Closed
JamesMGreene wants to merge 1 commit intonodejs:masterfrom
JamesMGreene:cnl_first_task
Closed
test: update 'fixturesDir' refs in a test file#15824JamesMGreene wants to merge 1 commit intonodejs:masterfrom JamesMGreene:cnl_first_task
JamesMGreene wants to merge 1 commit intonodejs:masterfrom
JamesMGreene:cnl_first_task
Conversation
pawelgolda
reviewed
Oct 6, 2017
Contributor
There was a problem hiding this comment.
This could be using method fixtures.readKey instead of fs.readFileSync to get the keys.
Contributor
Author
There was a problem hiding this comment.
Good call. I followed the distributed Code & Learn task description pretty literally, so this thought never occurred to me. Thanks for the tip. 👍
Contributor
Author
There was a problem hiding this comment.
P.S. Updated with another commit.
Member
This was a task from Code & Learn at NINA17.
Contributor
Author
|
I've squashed the commits for this. |
rmg
approved these changes
Oct 6, 2017
Contributor
rmg
left a comment
There was a problem hiding this comment.
This looks great! Thanks for contributing!
Contributor
|
Welcome @JamesMGreene and thank you for the contribution 🥇 Resumed the CI jobs that failed because of git issues: |
refack
approved these changes
Oct 6, 2017
Contributor
Author
|
Thanks for the resume, @refack. 👍 |
richardlau
approved these changes
Oct 6, 2017
cjihrig
approved these changes
Oct 6, 2017
benjamingr
approved these changes
Oct 7, 2017
tniessen
approved these changes
Oct 7, 2017
refack
pushed a commit
that referenced
this pull request
Oct 7, 2017
This was a task from Code & Learn at NINA17. PR-URL: #15824 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Contributor
|
Landed in 1c97fa7 |
Contributor
Author
|
\o/ :tada: And thank you in turn to all of the Node.js collaborators and NINA17 mentors for allowing us the opportunity for an “easy in”. 👍 |
Contributor
Author
|
I know it’s a lot more work on your end than just doing it yourselves but it’s a brilliant way to get new contributors involved. |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
This was a task from Code & Learn at NINA17. PR-URL: #15824 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
This was a task from Code & Learn at NINA17. PR-URL: nodejs/node#15824 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
This was a task from Code & Learn at NINA17. PR-URL: #15824 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
This was a task from Code & Learn at NINA17. PR-URL: #15824 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
This was a task from Code & Learn at NINA17. PR-URL: #15824 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a task from Code & Learn at NINA17.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Thanks @jasnell 💝