test: change usage from common.fixturesDir to fixturesDir#15925
Closed
wonk wants to merge 2 commits intonodejs:masterfrom
wonk:UseFixturesForFixturesDir
Closed
test: change usage from common.fixturesDir to fixturesDir#15925wonk wants to merge 2 commits intonodejs:masterfrom wonk:UseFixturesForFixturesDir
wonk wants to merge 2 commits intonodejs:masterfrom
wonk:UseFixturesForFixturesDir
Conversation
Now use the common.fixtures module directly to reference fixturesDir, bypassing common module.
…nc(). Use fixtures.readKey() to read keys. Bypass usage of commons module for keys, and avoid hard-coding directories into keys access. Remove usage of fs module. [Courtesy "NodeJS Interactive 2017" Code & Learn 'first-time pull request' task.]
BridgeAR
approved these changes
Oct 9, 2017
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2017
PR-URL: #15925 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in c4178ab Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15925 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15925 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #15925 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15925 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15925 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now use the common.fixtures module directly to reference fixturesDir, bypassing common module.