test: replaced common.fixturesDir with common.fixtures module usage#15933
Closed
letthewookieewin wants to merge 4 commits intonodejs:masterfrom
letthewookieewin:master
Closed
test: replaced common.fixturesDir with common.fixtures module usage#15933letthewookieewin wants to merge 4 commits intonodejs:masterfrom letthewookieewin:master
letthewookieewin wants to merge 4 commits intonodejs:masterfrom
letthewookieewin:master
Conversation
pawelgolda
reviewed
Oct 6, 2017
| const options = { | ||
| key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`), | ||
| cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`) | ||
| key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-key.pem`), |
Contributor
There was a problem hiding this comment.
This could be using method fixtures.readKey instead of fs.readFileSync to get the keys.
Contributor
Author
There was a problem hiding this comment.
D'oh! Updated to use fixtures.readKey and fixtures.readSync (for the cert).
Contributor
Author
Checklist
Affected core subsystem(s)test |
BridgeAR
approved these changes
Oct 7, 2017
tniessen
approved these changes
Oct 7, 2017
cjihrig
approved these changes
Oct 7, 2017
Member
danbev
approved these changes
Oct 8, 2017
gibfahn
approved these changes
Oct 8, 2017
Member
|
Landed in b050c14 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
gibfahn
pushed a commit
that referenced
this pull request
Oct 8, 2017
PR-URL: #15933 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Contributor
Author
|
Thanks @joyeecheung @danbev @cjihrig @tniessen, and special thanks to @gibfahn for the help at the conference with this. Now, on to my next contribution! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15933 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15933 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #15933 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15933 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15933 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test