Skip to content

test: use common.crashOnUnhandledRejection#17235

Closed
Kcin1993 wants to merge 1 commit intonodejs:masterfrom
Kcin1993:first-commit
Closed

test: use common.crashOnUnhandledRejection#17235
Kcin1993 wants to merge 1 commit intonodejs:masterfrom
Kcin1993:first-commit

Conversation

@Kcin1993
Copy link
Contributor

@Kcin1993 Kcin1993 commented Nov 22, 2017 •
edited
Loading

Add common.crashOnUnhandledRejection to test/parallel/test-microtask-queue-run-immediate-domain.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@Kcin1993
test: use common.crashOnUnhandledRejection
fdba564 
Add common.crashOnUnhandledRejection to path: test/parallel/test-microtask-queue-run-immediate-domain.js
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
MylesBorins
MylesBorins approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@mscdex mscdex added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Nov 22, 2017
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 23, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11653/

@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 26, 2017

landed in e4f5c63

Made slight tweak to commit message

MylesBorins pushed a commit that referenced this pull request Nov 26, 2017
@Kcin1993 @MylesBorins
test: use common.crashOnUnhandledRejection
e4f5c63 
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 26, 2017

@maclover7 another one where the linter wasn't run but issue is reported as green

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Kcin1993 @MylesBorins
test: use common.crashOnUnhandledRejection
28ff3f4 
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Kcin1993 @MylesBorins
test: use common.crashOnUnhandledRejection
24b1839 
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@Kcin1993 @gibfahn
test: use common.crashOnUnhandledRejection
8c8a2fd 
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@Kcin1993 @gibfahn
test: use common.crashOnUnhandledRejection
75ad37c 
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Kcin1993 @gibfahn
test: use common.crashOnUnhandledRejection
2d697a8 
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+1 more reviewer

@MylesBorins MylesBorins MylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Kcin1993 @MylesBorins @jasnell @cjihrig @gireeshpunathil @mscdex @gibfahn @nodejs-github-bot