doc: update my name in AUTHORS.txt, add the updated version to .mailmap#17239
Closed
mgol wants to merge 1 commit intonodejs:masterfrom
Closed
doc: update my name in AUTHORS.txt, add the updated version to .mailmap#17239mgol wants to merge 1 commit intonodejs:masterfrom
mgol wants to merge 1 commit intonodejs:masterfrom
Conversation
aqrln
approved these changes
Nov 22, 2017
Contributor
|
landed in f3b12aa slight modification to commit message |
mgol
added a commit
to mgol/node
that referenced
this pull request
Nov 22, 2017
PR-URL: nodejs#17239 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17239 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17239 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17239 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17239 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17239 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (I can't check it due to Cannot build Node on macOS: "No acceptable C compiler found!" #17238)Affected core subsystem(s)
doc