tools: add docs for prefer-util-format-errors rule#17376
Closed
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-doc-rule
Closed
tools: add docs for prefer-util-format-errors rule#17376maclover7 wants to merge 1 commit intonodejs:masterfrom maclover7:jm-doc-rule
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-doc-rule
Conversation
I had a little trouble understanding what the rule was trying to say, so am documenting what would pass/fail.
apapirovski
approved these changes
Nov 28, 2017
Trott
approved these changes
Nov 28, 2017
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM. One possible minor improvements if you feel so inclined: Show what the failing example could be rewritten as and (if it's not immediately obvious) an explanation of why it's better than the failing code.
cjihrig
approved these changes
Nov 28, 2017
Contributor
|
Just an FYI, the tests for these lint rules can also often be used as supplementary information. For this rule: https://github.com/nodejs/node/blob/master/test/parallel/test-eslint-prefer-util-format-errors.js |
Contributor
Author
|
CI looks to be passing: https://ci.nodejs.org/job/node-test-commit/14481/, landing... |
Contributor
Author
|
Landed in 85e34b0 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
I had a little trouble understanding what the rule was trying to say, so am documenting what would pass/fail. PR-URL: #17376 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
I had a little trouble understanding what the rule was trying to say, so am documenting what would pass/fail. PR-URL: #17376 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a little trouble understanding what the rule was trying to say, so
am documenting what would pass/fail.
Checklist
Affected core subsystem(s)
tools