Closed
Conversation
Update remark-preset-lint-node to version at commit hash 859eab541e0f63839b33196f26e2bed4dfe2b194. This is the most recent version at this time (although not yet published to npm). It includes linting for "v8" where "V8" is intended and "Javascript" Where "JavaScript" is intended. By installing those lint rules now rather than waiting for a published version, we avoid the possibility that new markdown text with those prohibited strings will be introduced.
Member
Author
|
/cc @watilde |
maclover7
approved these changes
Nov 29, 2017
Contributor
maclover7
left a comment
There was a problem hiding this comment.
LGTM, but would it be possible to move the module to live in nodejs/node, and not have it be in a separate repo? It seems like it's just an index.js file with the rule configuration.
Member
Author
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 1, 2017
Update remark-preset-lint-node to version at commit hash 859eab541e0f63839b33196f26e2bed4dfe2b194. This is the most recent version at this time (although not yet published to npm). It includes linting for "v8" where "V8" is intended and "Javascript" Where "JavaScript" is intended. By installing those lint rules now rather than waiting for a published version, we avoid the possibility that new markdown text with those prohibited strings will be introduced. PR-URL: nodejs#17382 Reviewed-By: Jon Moss <me@jonathanmoss.me>
Member
Author
|
Landed in c589561. |
Member
Author
(Deleted my previous response to this because I misread/misunderstood. Trying again.) Current answer: ping @watilde |
Member
Author
|
Marked as do-not-land on 8.x and earlier because new rule depends on RegExp features in 9.x and later. 😮 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Update remark-preset-lint-node to version at commit hash 859eab541e0f63839b33196f26e2bed4dfe2b194. This is the most recent version at this time (although not yet published to npm). It includes linting for "v8" where "V8" is intended and "Javascript" Where "JavaScript" is intended. By installing those lint rules now rather than waiting for a published version, we avoid the possibility that new markdown text with those prohibited strings will be introduced. PR-URL: #17382 Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Update remark-preset-lint-node to version at commit hash 859eab541e0f63839b33196f26e2bed4dfe2b194. This is the most recent version at this time (although not yet published to npm). It includes linting for "v8" where "V8" is intended and "Javascript" Where "JavaScript" is intended. By installing those lint rules now rather than waiting for a published version, we avoid the possibility that new markdown text with those prohibited strings will be introduced. PR-URL: #17382 Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update remark-preset-lint-node to version at commit hash
859eab541e0f63839b33196f26e2bed4dfe2b194. This is the most recent
version at this time (although not yet published to npm). It includes
linting for "v8" where "V8" is intended and "Javascript" Where
"JavaScript" is intended. By installing those lint rules now rather than
waiting for a published version, we avoid the possibility that new
markdown text with those prohibited strings will be introduced.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools