Skip to content

test: fix flaky test-benchmark-misc#17686

Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:fix-misc
Closed

test: fix flaky test-benchmark-misc#17686
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:fix-misc

Conversation

@Trott
Copy link
Member

@Trott Trott commented Dec 14, 2017

Allow zero results for short benchmark test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test benchmark

@Trott
test: fix flaky test-benchmark-misc
f0c4153 
Allow zero results for short benchmark test.
@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. labels Dec 14, 2017
@Trott
Copy link
Member Author

Trott commented Dec 14, 2017

Sample failure without this change: https://ci.nodejs.org/job/node-test-commit-linux/14918/nodes=alpine35-container-x64/consoleText

not ok 152 parallel/test-benchmark-misc
  ---
  duration_ms: 4.974
  severity: fail
  stack: |-
    
    misc/console.js
    misc/console.js n=1 concat=0 method="": 275.9450427852789
    
    misc/freelist.js
    misc/freelist.js n=1: 491.6860800720615
    
    misc/function_call
    
    misc/object-property-bench.js
    misc/function_call.js Binding failed to load
    /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/common.js:202
          throw new Error('insufficient clock precision for short benchmark');
          ^
    
    Error: insufficient clock precision for short benchmark
        at Benchmark.end (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/common.js:202:13)
        at runProperty (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/misc/object-property-bench.js:19:9)
        at main (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/misc/object-property-bench.js:69:7)
        at Benchmark.process.nextTick (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/common.js:34:28)
        at process._tickCallback (internal/process/next_tick.js:150:11)
        at Function.Module.runMain (module.js:703:11)
        at startup (bootstrap_node.js:195:16)
        at bootstrap_node.js:646:3
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: 1 strictEqual 0
        at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/test/common/benchmark.js:25:12)
        at ChildProcess.emit (events.js:126:13)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)
  ...

@Trott
Copy link
Member Author

Trott commented Dec 14, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12106/

@Trott
Copy link
Member Author

Trott commented Dec 14, 2017

LinuxONE build failure unrelated. Re-run: https://ci.nodejs.org/job/node-test-commit-linuxone/11172/

@Trott
Copy link
Member Author

Trott commented Dec 15, 2017

Unrelated build failures on linux. Re-running: https://ci.nodejs.org/job/node-test-commit-linux/14967/

@Trott
Copy link
Member Author

Trott commented Dec 15, 2017

Windows build failures. Re-run: https://ci.nodejs.org/job/node-test-binary-windows/13640/

@Trott
Copy link
Member Author

Trott commented Dec 15, 2017

CI was having general issues yesterday. Seems to be cleared up. So one more time...

CI: https://ci.nodejs.org/job/node-test-pull-request/12126/

Trott added a commit to Trott/io.js that referenced this pull request Dec 15, 2017
@Trott
test: fix flaky test-benchmark-misc
eecea2e 
Allow zero results for short benchmark test.

PR-URL: nodejs#17686
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Dec 15, 2017

Landed in eecea2e

@Trott Trott closed this Dec 15, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Trott @MylesBorins
test: fix flaky test-benchmark-misc
b826528 
Allow zero results for short benchmark test.

PR-URL: #17686
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@Trott @MylesBorins
test: fix flaky test-benchmark-misc
9d3e4c0 
Allow zero results for short benchmark test.

PR-URL: #17686
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@Trott @gibfahn
test: fix flaky test-benchmark-misc
d1c854f 
Allow zero results for short benchmark test.

PR-URL: #17686
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the fix-misc branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@apapirovski apapirovski apapirovski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott @apapirovski @jasnell @cjihrig @MylesBorins