path: refactor to reduce duplicated codes#18594
Closed
starkwang wants to merge 2 commits intonodejs:masterfrom
Closed
path: refactor to reduce duplicated codes#18594starkwang wants to merge 2 commits intonodejs:masterfrom
starkwang wants to merge 2 commits intonodejs:masterfrom
Conversation
Contributor
Author
There are many duplicated codes in methods such as `normalizeString`, `format`, `extname` and `basename`. This change is to reduce them.
6e62251 to
c68ada1
Compare
daynin
reviewed
Feb 8, 2018
| var lastSlash = -1; | ||
| var dots = 0; | ||
| var code; | ||
| var slashChar = win32 ? '\\' : '/'; |
|
|
||
| function _extname(path, win32) { | ||
| assertPath(path); | ||
| var start = 0; |
Contributor
There was a problem hiding this comment.
let's use let/const instead of var in places where in possible
Contributor
Author
|
This PR will be rebased after another PR (#18654) lands. |
Member
|
This needs a rebase. |
Contributor
Author
|
This PR is out of date and hard to rebase. I'll open another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many duplicated codes in methods such as
normalizeString,format,extnameandbasename.This change is to reduce them.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
path