stream: add no-half-open enforcer only if needed#18953
Closed
lpinca wants to merge 1 commit intonodejs:masterfrom
Closed
stream: add no-half-open enforcer only if needed#18953lpinca wants to merge 1 commit intonodejs:masterfrom
lpinca wants to merge 1 commit intonodejs:masterfrom
Conversation
The listener does not do anything if `allowHalfOpen` is enabled. Add it only when `allowHalfOpen` is disabled.
Member
Author
tniessen
approved these changes
Feb 23, 2018
BridgeAR
approved these changes
Feb 24, 2018
mcollina
approved these changes
Feb 27, 2018
Member
mcollina
left a comment
There was a problem hiding this comment.
LGTM.
Please also do a full CITGM run.
Member
Author
jasnell
approved these changes
Feb 27, 2018
Contributor
Contributor
|
Landed in f2b9805 |
apapirovski
pushed a commit
that referenced
this pull request
Mar 4, 2018
The listener does not do anything if `allowHalfOpen` is enabled. Add it only when `allowHalfOpen` is disabled. PR-URL: #18953 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
4 tasks
Contributor
|
Should this be backported to |
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Mar 7, 2018
The listener does not do anything if `allowHalfOpen` is enabled. Add it only when `allowHalfOpen` is disabled. PR-URL: nodejs#18953 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
The listener does not do anything if `allowHalfOpen` is enabled. Add it only when `allowHalfOpen` is disabled. PR-URL: #18953 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
The listener does not do anything if `allowHalfOpen` is enabled. Add it only when `allowHalfOpen` is disabled. PR-URL: #18953 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
This seems to have caused a breakage. Should not be backported to LTS until a fix is found #19764 |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
The listener does not do anything if `allowHalfOpen` is enabled. Add it only when `allowHalfOpen` is disabled. PR-URL: nodejs#18953 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Should this be backported to 8.x now? |
Member
|
I would not backport this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The listener does not do anything if
allowHalfOpenis enabled. Add it only whenallowHalfOpenis disabled.If
allowHalfOpencan be changed on the fly this PR doesn't make sense and should be closed.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
stream