test: specify 'dir' for directory symlinks#19049
Closed
kfarnung wants to merge 1 commit intonodejs:masterfrom
Closed
test: specify 'dir' for directory symlinks#19049kfarnung wants to merge 1 commit intonodejs:masterfrom
kfarnung wants to merge 1 commit intonodejs:masterfrom
Conversation
richardlau
approved these changes
Feb 27, 2018
XadillaX
approved these changes
Feb 28, 2018
cjihrig
approved these changes
Feb 28, 2018
lpinca
approved these changes
Feb 28, 2018
danbev
approved these changes
Feb 28, 2018
jasnell
approved these changes
Feb 28, 2018
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly.
Contributor
Author
BridgeAR
approved these changes
Mar 1, 2018
Contributor
Author
|
Landed in 148f402 |
kfarnung
added a commit
that referenced
this pull request
Mar 2, 2018
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. PR-URL: #19049 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Mar 5, 2018
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. PR-URL: nodejs#19049 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. PR-URL: nodejs/node#19049 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. PR-URL: nodejs/node#19049 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. PR-URL: nodejs/node#19049 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 7, 2018
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. PR-URL: nodejs/node#19049 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. PR-URL: nodejs#19049 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 17, 2018
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. PR-URL: nodejs#19049 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 6, 2018
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. Backport-PR-URL: #22380 PR-URL: #19049 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test