node_api: fix uncaught exceptions in async worker#19336
Closed
mafintosh wants to merge 2 commits intonodejs:masterfrom
Closed
node_api: fix uncaught exceptions in async worker#19336mafintosh wants to merge 2 commits intonodejs:masterfrom
mafintosh wants to merge 2 commits intonodejs:masterfrom
Conversation
cab3960 to
6465517
Compare
jasnell
approved these changes
Mar 14, 2018
addaleax
approved these changes
Mar 14, 2018
richardlau
reviewed
Mar 14, 2018
Member
richardlau
left a comment
There was a problem hiding this comment.
For consistency, the subsystem should be n-api.
6465517 to
b082520
Compare
Member
Author
|
@richardlau fixed |
Member
Author
|
Was fixed by my other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis fixes an issue with n-api where an uncaught exception triggered in the async worker callback
would lead to js weirdness or node panics.
The main issue was we were calling js functions after doing
isolate->ThrowExceptionwhich the v8 documentation states is illegalFix is to simply use the other FatalException interface which allows passing in the local value and message directly.
I've added a test that showcases the problem as well (panics on my machine)