Closed
Conversation
Contributor
Author
lib/internal/async_hooks.js
Outdated
Member
There was a problem hiding this comment.
I'm not sure if I like these kinds of abstractions, but for sure it seems that from and to should be switched.
Member
There was a problem hiding this comment.
Maybe call it copyHooks? Maybe it’s just my C background that sees parallels to memcpy() & co here, but it seems closer to what’s happening than setHooks?
Contributor
Author
There was a problem hiding this comment.
I like copyHooks, I'll update the PR. Thanks
Contributor
Author
There was a problem hiding this comment.
@AndreasMadsen I'll also changed the parameters, so it will be copyHooks(destination, source).
addaleax
approved these changes
Mar 16, 2018
lib/internal/async_hooks.js
Outdated
Member
There was a problem hiding this comment.
Maybe call it copyHooks? Maybe it’s just my C background that sees parallels to memcpy() & co here, but it seems closer to what’s happening than setHooks?
apapirovski
approved these changes
Mar 17, 2018
Contributor
apapirovski
left a comment
There was a problem hiding this comment.
+1 on naming it copyHooks
This commit introduces a copyHooks function that can be used by storeActiveHooks and restoreActiveHooks to remove some code duplication.
2045c5e to
657a33d
Compare
Contributor
Author
|
Rebased and updated CI: https://ci.nodejs.org/job/node-test-pull-request/13726/ |
Contributor
Author
node-test-commit failure looks unrelated06:55:35 Building addon /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/addons-napi/test_array/
06:55:35 gyp info it worked if it ends with ok
06:55:35 gyp info using node-gyp@3.6.2
06:55:35 gyp info using node@10.0.0-pre | linux | x64
06:55:35 gyp info chdir /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/addons-napi/test_array/
06:55:35 Aborted (core dumped)
06:55:35 Makefile:369: recipe for target 'test/addons-napi/.buildstamp' failed
06:55:35 make[1]: *** [test/addons-napi/.buildstamp] Error 1
06:55:35 make[1]: *** Waiting for unfinished jobs....
06:55:49 |
Contributor
Author
|
Landed in 5a4a1cb. |
danbev
added a commit
that referenced
this pull request
Mar 20, 2018
This commit introduces a copyHooks function that can be used by storeActiveHooks and restoreActiveHooks to remove some code duplication. PR-URL: #19391 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
This commit introduces a copyHooks function that can be used by storeActiveHooks and restoreActiveHooks to remove some code duplication. PR-URL: #19391 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
This commit introduces a copyHooks function that can be used by storeActiveHooks and restoreActiveHooks to remove some code duplication. PR-URL: #19391 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a copyHooks function that can be used by
storeActiveHooks and restoreActiveHooks to remove some code duplication.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes