test: mark test-zlib.zlib-binding.deflate as flaky#20935
Closed
mmarchini wants to merge 1 commit intonodejs:masterfrom
Closed
test: mark test-zlib.zlib-binding.deflate as flaky#20935mmarchini wants to merge 1 commit intonodejs:masterfrom
mmarchini wants to merge 1 commit intonodejs:masterfrom
Conversation
test-zlib.zlib-binding.deflate is failing continuously in our CI, leaving us with 1% successful builds during the last 100 runs. This commit marks the test as flaky while the issue is not resolved. Ref: nodejs#20907
Contributor
Author
|
Please leave a 👍 if you agree this PR should be fast-tracked. |
Contributor
Author
apapirovski
approved these changes
May 24, 2018
Contributor
apapirovski
left a comment
There was a problem hiding this comment.
LGTM. Is linuxone the same as linux for the purposes of these status files?
Contributor
Author
Not sure, I was thinking the same thing while making this PR. Maybe someone from @nodejs/build can answer that? |
Contributor
I believe so, yes |
cjihrig
approved these changes
May 24, 2018
BridgeAR
approved these changes
May 24, 2018
Contributor
|
@nodejs/collaborators please have a look and also 👍 above to approve the fast-tracking. This way we can get the CI green / yellow again. |
richardlau
approved these changes
May 24, 2018
benjamingr
approved these changes
May 24, 2018
Member
Yes, linuxone is Linux on z/Architecture ( |
Contributor
Author
|
Landing |
Contributor
Author
|
Landed in f96ef55 |
mmarchini
pushed a commit
that referenced
this pull request
May 24, 2018
test-zlib.zlib-binding.deflate is failing continuously in our CI, leaving us with 1% successful builds during the last 100 runs. This commit marks the test as flaky while the issue is not resolved. Ref: #20907 PR-URL: #20935 Refs: #20907 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 24, 2018
test-zlib.zlib-binding.deflate is failing continuously in our CI, leaving us with 1% successful builds during the last 100 runs. This commit marks the test as flaky while the issue is not resolved. Ref: #20907 PR-URL: #20935 Refs: #20907 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.
Ref: #20907
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes