src: remove .h if -inl.h is already included#21381
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove .h if -inl.h is already included#21381danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE.
Contributor
Author
mmarchini
approved these changes
Jun 18, 2018
devsnek
approved these changes
Jun 18, 2018
lpinca
approved these changes
Jun 18, 2018
BridgeAR
approved these changes
Jun 18, 2018
Contributor
Author
node-test-commit-windows-fanned failure looks unrelatednot ok 491 parallel/test-worker-memory
---
duration_ms: 1.413
severity: fail
exitcode: 1
stack: |-
Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
at Object.exports.mustCall (c:\workspace\node-test-binary-windows\test\common\index.js:428:10)
at run (c:\workspace\node-test-binary-windows\test\parallel\test-worker-memory.js:21:28)
at Worker.worker.on.common.mustCall (c:\workspace\node-test-binary-windows\test\parallel\test-worker-memory.js:22:5)
at Worker.<anonymous> (c:\workspace\node-test-binary-windows\test\common\index.js:468:15)
at Worker.emit (events.js:182:13)
at Worker.[kOnExit] (internal/worker.js:270:10)
at Worker.(anonymous function).onexit (internal/worker.js:226:51)
... |
cjihrig
approved these changes
Jun 18, 2018
bnoordhuis
approved these changes
Jun 18, 2018
Member
bnoordhuis
left a comment
There was a problem hiding this comment.
Might be nice as an enhancement to have cpplint.py or check-imports.sh enforce this.
TimothyGu
approved these changes
Jun 18, 2018
ryzokuken
approved these changes
Jun 18, 2018
Contributor
Author
Yeah, I what would make sense. I'll take a look but might not have time this week by the looks of things. |
Contributor
|
@danbev if it's okay, I guess this could be landed and I could help out with the linting in a separate PR. |
Contributor
Author
That would be great, thanks! |
Contributor
Author
|
Landed in a71d5fc. |
danbev
added a commit
that referenced
this pull request
Jun 20, 2018
This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. PR-URL: #21381 Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Member
|
Should land cleanly on v10.x-staging after #21105 is backported |
targos
pushed a commit
that referenced
this pull request
Jul 14, 2018
This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. PR-URL: #21381 Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Merged
This was referenced Jul 18, 2018
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the normal header file include if an internal one
is specified as per the CPP_STYLE_GUIDE.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes