src: slightly simplify FSEventWrap#21533
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
We don’t need to track `initialized_`, `HandleWrap` already does that for us.
eugeneo
approved these changes
Jun 25, 2018
Member
Author
joyeecheung
approved these changes
Jun 26, 2018
apapirovski
approved these changes
Jun 26, 2018
bnoordhuis
approved these changes
Jun 26, 2018
src/fs_event_wrap.cc
Outdated
| AsyncWrap::AddWrapMethods(env, t); | ||
| env->SetProtoMethod(t, "start", Start); | ||
| env->SetProtoMethod(t, "close", Close); | ||
| env->SetProtoMethod(t, "close", HandleWrap::Close); |
Member
There was a problem hiding this comment.
I'd use unqualified Close, that turns it into a build error if FSEventWrap stops being a HandleWrap.
Member
Author
cjihrig
approved these changes
Jun 26, 2018
jasnell
approved these changes
Jun 29, 2018
jasnell
pushed a commit
that referenced
this pull request
Jun 29, 2018
We don’t need to track `initialized_`, `HandleWrap` already does that for us. PR-URL: #21533 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in bf360d2 |
targos
pushed a commit
that referenced
this pull request
Jun 29, 2018
We don’t need to track `initialized_`, `HandleWrap` already does that for us. PR-URL: #21533 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don’t need to track
initialized_,HandleWrapalready doesthat for us.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes