doc: fix doc for napi_create_function#21627
Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fix doc for napi_create_function#21627gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Conversation
vsemozhetbyt
approved these changes
Jul 3, 2018
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
trivikr
approved these changes
Jul 4, 2018
Contributor
Author
cjihrig
approved these changes
Jul 5, 2018
Contributor
Author
|
Resumed build as: https://ci.nodejs.org/job/node-test-pull-request/15742/ |
Contributor
Author
|
Another attempt at resuming the build: https://ci.nodejs.org/job/node-test-pull-request/15743/ |
Merge the two duplicate entries for `napi_create_function()`. Fixes: nodejs#21606
084da9b to
6131981
Compare
Contributor
Author
|
This one actually finished: https://ci.nodejs.org/job/node-test-pull-request/15745/ |
Contributor
Author
|
Landed in e55bdde. |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Jul 6, 2018
Merge the two duplicate entries for `napi_create_function()`. Fixes: nodejs#21606 PR-URL: nodejs#21627 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the two duplicate entries for
napi_create_function().Fixes: #21606
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) has unrelated errors 😕