tools: install doc tools only when necessary#22217
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
tools: install doc tools only when necessary#22217joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
Marking tools/doc/node_modules as PHONY result in constant installation of the doctools whether it's changed or not (which means `make lint-addon-docs` always install the tools). Unmark it and fix the dependency to avoid unnecessary installations if the package.json is not changed.
Contributor
|
@joyeecheung I think this might be a duplicate of #22189? |
Member
Author
|
@danbev Ah, sorry, didn't notice that one. I'll close this, thanks for the reminder! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking tools/doc/node_modules as PHONY result in constant
installation of the doctools whether it's changed or not
(which means
make lint-addon-docsalways install the tools).Unmark it and fix the dependency to avoid unnecessary
installations if the package.json is not changed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes