spawn_sync: move process.binding('spawn_sync') to internalBinding#22260
Closed
antsmartian wants to merge 1 commit intonodejs:masterfrom
Closed
spawn_sync: move process.binding('spawn_sync') to internalBinding#22260antsmartian wants to merge 1 commit intonodejs:masterfrom
antsmartian wants to merge 1 commit intonodejs:masterfrom
Conversation
1286410 to
e86328f
Compare
33 tasks
cjihrig
approved these changes
Aug 11, 2018
trivikr
approved these changes
Aug 12, 2018
jdalton
suggested changes
Aug 13, 2018
Member
jdalton
left a comment
There was a problem hiding this comment.
Holding removals until migration is ironed out
Member
|
@antsmartian ... when you get a moment, can you rebase this on master then apply the following patch which will be necessary for this to proceed: Author: James M Snell <jasnell@gmail.com>
Date: Tue Aug 14 19:36:25 2018 -0700
[Squash] add `process.binding('spawn_sync')` to fallthrough whitelist
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 08daeb1915..ffae6e4cd9 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -327,7 +327,7 @@
// that are whitelisted for access via process.binding()... this is used
// to provide a transition path for modules that are being moved over to
// internalBinding.
- const internalBindingWhitelist = new SafeSet(['uv']);
+ const internalBindingWhitelist = new SafeSet(['uv', 'spawn_sync']);
process.binding = function binding(name) {
return internalBindingWhitelist.has(name) ?
internalBinding(name) :
diff --git a/test/parallel/test-process-binding-internalbinding-whitelist.js b/test/parallel/test-process-binding-internalbinding-whitelist.js
index ece967a0b7..cc0119917d 100644
--- a/test/parallel/test-process-binding-internalbinding-whitelist.js
+++ b/test/parallel/test-process-binding-internalbinding-whitelist.js
@@ -7,3 +7,4 @@ const assert = require('assert');
// Assert that whitelisted internalBinding modules are accessible via
// process.binding().
assert(process.binding('uv'));
+assert(process.binding('spawn_sync')); |
Contributor
Author
Contributor
Author
|
@jasnell Now it should be good to go, thanks! |
jdalton
approved these changes
Aug 15, 2018
b8ab324 to
221afde
Compare
Contributor
Author
|
@jasnell Have rebased, can we get this merge, before I get an another conflict :) Thanks for your help. |
Contributor
Author
|
Ok seeing a lint issue, let me fix that. |
221afde to
b0addf2
Compare
BridgeAR
approved these changes
Sep 5, 2018
Member
Contributor
Author
|
Yet again conflicts, let me rebase it tonight.. sorry folks.. |
Member
|
Landed in 9c9c01f |
targos
pushed a commit
that referenced
this pull request
Sep 15, 2018
PR-URL: #22260 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
Author
|
@targos Thanks for rebasing, didn't find time to do it. Thanks a ton. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from process.binding to internalBinding (see : #22160)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes