doc: update wrapping-related documentation#22363
Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Closed
doc: update wrapping-related documentation#22363gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Aug 16, 2018
jasnell
approved these changes
Aug 16, 2018
lpinca
approved these changes
Aug 16, 2018
JungMinu
approved these changes
Aug 17, 2018
BridgeAR
approved these changes
Aug 17, 2018
Member
|
Collaborators, please +1 if you are fine to fast track this. |
trivikr
approved these changes
Aug 17, 2018
Contributor
Author
Contributor
Author
Contributor
Author
|
Resumed again as: https://ci.nodejs.org/job/node-test-pull-request/16602/ |
Contributor
Author
Update the N-API documentation to reflect that wrapping no longer affects the object's prototype chain.
af787f0 to
f6ba436
Compare
Contributor
Author
|
Rebased to hopefully fix CI. New CI: https://ci.nodejs.org/job/node-test-pull-request/16607/ |
Contributor
Author
|
CI Resumed as https://ci.nodejs.org/job/node-test-pull-request/16613/ |
Contributor
Author
|
And another CI from the top: https://ci.nodejs.org/job/node-test-pull-request/16614/ |
Contributor
Author
|
Landed in e19aa2663149fa2770d2cdfcca3ee54447fec2b7. |
Contributor
Author
|
sigh Forgot to |
gabrielschulhof
pushed a commit
that referenced
this pull request
Aug 21, 2018
Update the N-API documentation to reflect that wrapping no longer affects the object's prototype chain. PR-URL: #22363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 24, 2018
Update the N-API documentation to reflect that wrapping no longer affects the object's prototype chain. PR-URL: #22363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Update the N-API documentation to reflect that wrapping no longer affects the object's prototype chain. PR-URL: #22363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes