test: properly extend process.env in child_process#22430
Closed
legendecas wants to merge 1 commit intonodejs:masterfrom
Closed
test: properly extend process.env in child_process#22430legendecas wants to merge 1 commit intonodejs:masterfrom
legendecas wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
Aug 21, 2018
Member
addaleax
left a comment
There was a problem hiding this comment.
Looks good to me!
I'd be curious to hear how you figured this out -- did this cause real-world problems for you?
jasnell
approved these changes
Aug 21, 2018
cjihrig
approved these changes
Aug 21, 2018
Member
Author
Haha, yes, we're trying to applying node.js' test set to a node.js port (ShadowNode) for much more limited memory, and then picked out this nit on review :p |
BridgeAR
approved these changes
Aug 21, 2018
trivikr
approved these changes
Aug 22, 2018
Member
gdams
approved these changes
Aug 28, 2018
Member
|
landed in: dca2f98 Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
gdams
pushed a commit
that referenced
this pull request
Aug 28, 2018
PR-URL: #22430 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 28, 2018
PR-URL: #22430 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22430 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #22430 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesdocumentation is changed or added: no api has changedOptions on
child_process.spawnwas not properly constructed forprocess.envnot assigned tooptions.env.