doc: tweak macOS-firewall note position#22440
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
ZYSzys:building
Closed
doc: tweak macOS-firewall note position#22440ZYSzys wants to merge 1 commit intonodejs:masterfrom ZYSzys:building
ZYSzys wants to merge 1 commit intonodejs:masterfrom
ZYSzys:building
Conversation
Move the macOS-firewall note to the end of "Building Node.js" and above "Running Tests". I think it's more reasonable when user prepare to build node step by step. Just read and build from top to end in case ignore the note.
lpinca
approved these changes
Aug 21, 2018
vsemozhetbyt
approved these changes
Aug 21, 2018
Contributor
BridgeAR
approved these changes
Aug 21, 2018
jasnell
approved these changes
Aug 21, 2018
Member
|
note: the commit message prefix should be 'doc:` or 'meta:' |
cjihrig
approved these changes
Aug 22, 2018
trivikr
approved these changes
Aug 22, 2018
Member
Author
|
@jasnell Yeah, I‘ll pay attention to it next time. Do I have to fix the commit message prefix for this now ? |
Contributor
|
Landed in 56e331a |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Aug 24, 2018
Move the macOS-firewall note to the end of "Building Node.js" and above "Running Tests". I think it's more reasonable when user prepare to build node step by step. Just read and build from top to end in case ignore the note. PR-URL: #22440 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Aug 24, 2018
Move the macOS-firewall note to the end of "Building Node.js" and above "Running Tests". I think it's more reasonable when user prepare to build node step by step. Just read and build from top to end in case ignore the note. PR-URL: #22440 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Move the macOS-firewall note to the end of "Building Node.js" and above "Running Tests". I think it's more reasonable when user prepare to build node step by step. Just read and build from top to end in case ignore the note. PR-URL: #22440 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the macOS-firewall note to the end of "Building Node.js" and above "Running Tests".
I think it's more reasonable when user prepare to build node step by step.
Just read and build from top to end in case ignore the note.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes