build: use 0o octal notation in configure#22536
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
build: use 0o octal notation in configure#22536addaleax wants to merge 1 commit intonodejs:masterfrom
0o octal notation in configure#22536addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
This un-‘breaks’ the error message we print when using Python 3 to run `configure`. Refs: nodejs/help#1457
devsnek
approved these changes
Aug 26, 2018
cjihrig
approved these changes
Aug 26, 2018
refack
approved these changes
Aug 26, 2018
Contributor
|
/CC @nodejs/build-files @nodejs/python |
richardlau
approved these changes
Aug 26, 2018
joyeecheung
approved these changes
Aug 26, 2018
BridgeAR
approved these changes
Aug 26, 2018
thefourtheye
approved these changes
Aug 27, 2018
jasnell
approved these changes
Aug 27, 2018
Member
Author
|
Landed in 36c56db |
addaleax
added a commit
that referenced
this pull request
Aug 31, 2018
This un-‘breaks’ the error message we print when using Python 3 to run `configure`. Refs: nodejs/help#1457 PR-URL: #22536 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
that referenced
this pull request
Aug 31, 2018
This un-‘breaks’ the error message we print when using Python 3 to run `configure`. Refs: nodejs/help#1457 PR-URL: #22536 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
This un-‘breaks’ the error message we print when using Python 3 to run `configure`. Refs: nodejs/help#1457 PR-URL: #22536 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
This un-‘breaks’ the error message we print when using Python 3 to run `configure`. Refs: nodejs/help#1457 PR-URL: #22536 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This un-‘breaks’ the error message we print when using
Python 3 to run
configure.Refs: nodejs/help#1457
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes