tools: specify ESLint rules being disabled in two files#22563
Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Closed
tools: specify ESLint rules being disabled in two files#22563Trott wants to merge 2 commits intonodejs:masterfrom
Trott wants to merge 2 commits intonodejs:masterfrom
Conversation
Member
Author
|
Can't seem to start a full CI at the moment, but perhaps the Lite CI is enough since this changes comments only, so linting is the thing to check? |
Member
Author
|
Please 👍 here for fast-tracking. |
vsemozhetbyt
approved these changes
Aug 28, 2018
Contributor
|
Something wrong with CI lite (rebasing?) happens now. In this PR CI lite has a wrong commit: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/710/ (In this PR last CI lite had many wrong commits: #22170) |
cjihrig
approved these changes
Aug 28, 2018
trivikr
approved these changes
Aug 28, 2018
Member
Author
richardlau
requested changes
Aug 28, 2018
test/parallel/test-assert.js
Outdated
Member
There was a problem hiding this comment.
CI is failing because the message check in L701-L712 needs to be updated to match.
test/parallel/test-assert.js
Outdated
Member
There was a problem hiding this comment.
CI is failing because the message check in L725-L736 needs to be updated to match.
Instead of disabling all ESLint rules for a line, specify the two rules that should be disabled.
Instead of disabling all ESLint rules on two lines in test-assert.js, specify the rule that needs to be disabled.
9322ce3 to
26af2e5
Compare
Member
Author
richardlau
approved these changes
Aug 29, 2018
Member
Author
BridgeAR
approved these changes
Aug 31, 2018
Member
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
Instead of disabling all ESLint rules for a line, specify the two rules that should be disabled. PR-URL: #22563 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
Instead of disabling all ESLint rules on two lines in test-assert.js, specify the rule that needs to be disabled. PR-URL: #22563 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
Instead of disabling all ESLint rules for a line, specify the two rules that should be disabled. PR-URL: #22563 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
Instead of disabling all ESLint rules on two lines in test-assert.js, specify the rule that needs to be disabled. PR-URL: #22563 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Instead of disabling all ESLint rules for a line, specify the two rules that should be disabled. PR-URL: #22563 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Instead of disabling all ESLint rules on two lines in test-assert.js, specify the rule that needs to be disabled. PR-URL: #22563 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Instead of disabling all ESLint rules for a line, specify the two rules that should be disabled. PR-URL: #22563 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Instead of disabling all ESLint rules on two lines in test-assert.js, specify the rule that needs to be disabled. PR-URL: #22563 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of disabling all ESLint rules, just disable the rules necessary.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes