Merged
Conversation
danbev
approved these changes
Sep 3, 2018
addaleax
approved these changes
Sep 3, 2018
Member
Author
|
Since this test is not run in our usual CI run, we have to use the custom-suites job to exercise it. Other than that, the lint job is the only thing that is affected by it. CI: https://ci.nodejs.org/job/node-test-commit-custom-suites/678/ (And here's the one from node-daily-master last night showing it failing: https://ci.nodejs.org/job/node-test-commit-custom-suites/675/) |
Member
Author
|
Lint is green, custom job is green. Full CI out of abundance of caution (as this thing shouldn't be executed in a ordinary CI): https://ci.nodejs.org/job/node-test-pull-request/16989/ |
cjihrig
approved these changes
Sep 3, 2018
refack
approved these changes
Sep 3, 2018
Test is using `common.fileExists()` which has been removed. There is no need to check that the file exists as the attempt to read the file in the next line will fail if the file does not exist. Remove existence check. PR-URL: nodejs#22674 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Contributor
|
Fast-tracked (👍 by refack, danbev, and addaleax). Landed in 120814b |
addaleax
pushed a commit
that referenced
this pull request
Sep 3, 2018
Test is using `common.fileExists()` which has been removed. There is no need to check that the file exists as the attempt to read the file in the next line will fail if the file does not exist. Remove existence check. PR-URL: #22674 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 5, 2018
Test is using `common.fileExists()` which has been removed. There is no need to check that the file exists as the attempt to read the file in the next line will fail if the file does not exist. Remove existence check. PR-URL: #22674 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Test is using `common.fileExists()` which has been removed. There is no need to check that the file exists as the attempt to read the file in the next line will fail if the file does not exist. Remove existence check. PR-URL: #22674 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test is using
common.fileExists()which has been removed. There is noneed to check that the file exists as the attempt to read the file in
the next line will fail if the file does not exist. Remove existence
check.
This has broken node-daily-master (as that's where internet tests are run). Please 👍 to fast-track to get it fixed.
@nodejs/testing
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes