src: unique_ptrs in few lambdas in src/node_file.cc#23124
Closed
gireeshpunathil wants to merge 1 commit intonodejs:masterfrom
Closed
src: unique_ptrs in few lambdas in src/node_file.cc#23124gireeshpunathil wants to merge 1 commit intonodejs:masterfrom
gireeshpunathil wants to merge 1 commit intonodejs:masterfrom
Conversation
Few lambdas in src/node_file.cc uses conventional pointers, turn those into unique_ptr semantics
tniessen
approved these changes
Sep 27, 2018
thefourtheye
approved these changes
Sep 27, 2018
addaleax
approved these changes
Sep 27, 2018
jasnell
approved these changes
Sep 28, 2018
Member
cjihrig
approved these changes
Sep 30, 2018
Contributor
|
Landed in d407291. |
danbev
pushed a commit
that referenced
this pull request
Oct 1, 2018
Few lambdas in src/node_file.cc uses conventional pointers, turn those into unique_ptr semantics PR-URL: #23124 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 1, 2018
Few lambdas in src/node_file.cc uses conventional pointers, turn those into unique_ptr semantics PR-URL: #23124 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
Few lambdas in src/node_file.cc uses conventional pointers, turn those into unique_ptr semantics PR-URL: #23124 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few lambdas in
src/node_file.ccuses conventional pointers, turn those into unique_ptr semantics.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes