test: improve test-gc-http-client-onerror#23196
Closed
lundibundi wants to merge 1 commit intonodejs:masterfrom
Closed
test: improve test-gc-http-client-onerror#23196lundibundi wants to merge 1 commit intonodejs:masterfrom
lundibundi wants to merge 1 commit intonodejs:masterfrom
Conversation
jasnell
approved these changes
Oct 1, 2018
BridgeAR
approved these changes
Oct 1, 2018
Member
I think that might help with masking a real problem, see nodejs/reliability#18 (comment). |
* refactor out usage of 'function' for scoping * inline runTest function
330c8e3 to
acddd91
Compare
Member
Author
Member
|
Landed in 0ea804a |
addaleax
pushed a commit
that referenced
this pull request
Oct 12, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott
pushed a commit
that referenced
this pull request
Oct 13, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes