Skip to content

Comments

test: correct order of args in buffer compare#23521

Closed
rebolyte wants to merge 3 commits intonodejs:masterfrom
rebolyte:test-buffer-compare
Closed

test: correct order of args in buffer compare#23521
rebolyte wants to merge 3 commits intonodejs:masterfrom
rebolyte:test-buffer-compare

Conversation

@rebolyte
Copy link

@rebolyte rebolyte commented Oct 12, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@targos targos added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Oct 12, 2018
@digitalinfinity
Copy link
Contributor

digitalinfinity commented Oct 12, 2018

@rebolyte thanks for your PR- the change itself looks good to me but your git config needs a little tweak. Can you run the following command to set your email in your git config:
git config user.email "MY_NAME@example.com"

Then run git commit --amend --reset-author and push again
This is so that you're credited correctly for this PR (for instance, your github badge will change from "First time contributor" to "Contributor" once this PR lands if your email is correct)

(thanks to @gireeshpunthil for this tip!)

@rebolyte
Copy link
Author

rebolyte commented Oct 12, 2018

@digitalinfinity Thanks for the heads-up! I had a different email in my git config. Pushed with the new correct one.

@addaleax
Copy link
Member

addaleax commented Oct 16, 2018

@rebolyte Do you think you could rebase this against master? There’s a merge commit in here, and that doesn’t play too well with our CI…

@BridgeAR
Copy link
Member

BridgeAR commented Oct 17, 2018

I'll put together another PR later on that combines most of the open Code & Learn tasks and I will also resolve the merge in that case and run the CI on those before landing. I'll add the author-ready label due to that.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 17, 2018
@Trott
Copy link
Member

Trott commented Oct 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17962/

@Trott
Copy link
Member

Trott commented Oct 19, 2018

Landed in bef24e1.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Oct 19, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 19, 2018
@Trott
test: correct order of args in buffer compare
bef24e1 
PR-URL: nodejs#23521
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@addaleax
test: correct order of args in buffer compare
543efb9 
PR-URL: #23521
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
@jasnell
test: correct order of args in buffer compare
24e79bd 
PR-URL: #23521
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@MylesBorins
test: correct order of args in buffer compare
ff9232d 
PR-URL: #23521
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@rvagg
test: correct order of args in buffer compare
f96dc29 
PR-URL: #23521
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@MylesBorins
test: correct order of args in buffer compare
6baba1d 
PR-URL: #23521
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

+1 more reviewer

@digitalinfinity digitalinfinity digitalinfinity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@rebolyte @digitalinfinity @addaleax @BridgeAR @Trott @jasnell @cjihrig @trivikr @targos @nodejs-github-bot