test: fix arguments ordering for assertions to match the docs#23575
Closed
lirantal wants to merge 0 commit intonodejs:masterfrom
lirantal:master
Closed
test: fix arguments ordering for assertions to match the docs#23575lirantal wants to merge 0 commit intonodejs:masterfrom lirantal:master
lirantal wants to merge 0 commit intonodejs:masterfrom
lirantal:master
Conversation
digitalinfinity
approved these changes
Oct 12, 2018
BridgeAR
approved these changes
Oct 12, 2018
cjihrig
approved these changes
Oct 12, 2018
trivikr
approved these changes
Oct 12, 2018
Member
There was a problem hiding this comment.
looks like the above 2 asserts are identical. Not an issue of this PR, but does any one know whether it is intentional vs. accidental?
Member
Author
There was a problem hiding this comment.
good catch @gireeshpunathil, that change was introduced in 91a465c#diff-a00e02f229f04b6262da068e8df33ed5 and the version before that is b1506f7#diff-a00e02f229f04b6262da068e8df33ed5
Contributor
There was a problem hiding this comment.
Yup, one of them can be removed.
gireeshpunathil
approved these changes
Oct 13, 2018
thefourtheye
approved these changes
Oct 13, 2018
Contributor
There was a problem hiding this comment.
Yup, one of them can be removed.
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 15, 2018
PR-URL: nodejs#23575 Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Member
|
Not sure what happened here, but there seem to be some odd commits in here … @lirantal Could you rebase this against |
Member
Author
|
@addaleax looks like this PR has already landed in c596bcc#diff-a00e02f229f04b6262da068e8df33ed5 |
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
PR-URL: #23575 Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Oct 20, 2018
PR-URL: #23575 Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
PR-URL: #23575 Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23575 Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #23575 Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected
The test should make use of
strictEqual()according to the docs with the first value being theactual, and second being theexpectedActual
The use of
strictEqual()in the test uses the parameters backwardsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes