test: correct assertion argument order in test/sequential/test-inspector.js#23618
Closed
JeffMarvin wants to merge 1 commit intonodejs:masterfrom
Closed
test: correct assertion argument order in test/sequential/test-inspector.js#23618JeffMarvin wants to merge 1 commit intonodejs:masterfrom
JeffMarvin wants to merge 1 commit intonodejs:masterfrom
Conversation
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures.
BridgeAR
approved these changes
Oct 12, 2018
| assert.strictEqual( | ||
| response.length, | ||
| expectedResponseLength, | ||
| `Expected list response length to be ${expectedResponseLength}.` |
Member
There was a problem hiding this comment.
Nit: this removes important information because we do not know what the actual value actually is.
Contributor
Author
There was a problem hiding this comment.
@BridgeAR
I see that now. :)
Is it worth pushing a small fix for this? (It's easy enough for me to do, but I'm not sure if that will mess up your review process...)
Member
There was a problem hiding this comment.
@JeffMarvin It won't mess up the process, here are instructions on how to update the PR
We'll squash the commits before pushing it to master
jasnell
approved these changes
Oct 12, 2018
gireeshpunathil
approved these changes
Oct 13, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 15, 2018
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures. PR-URL: nodejs#23618 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 15, 2018
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures. PR-URL: nodejs#23618 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
|
Landed in 955148a 🎉 @JeffMarvin congratulations on your commit to Node.js! |
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures. PR-URL: #23618 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Oct 20, 2018
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures. PR-URL: #23618 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures. PR-URL: #23618 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures. PR-URL: #23618 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures. PR-URL: #23618 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes assertions in
sequential/test-inspector.jsconform to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes