Closed
Conversation
The warning is:
../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
^
../src/aliased_buffer.h:41:15: note: used here
buffer_ = Calloc<NativeT>(count);
danbev
approved these changes
Oct 29, 2018
addaleax
approved these changes
Oct 29, 2018
jasnell
approved these changes
Oct 29, 2018
bnoordhuis
approved these changes
Oct 29, 2018
Member
bnoordhuis
left a comment
There was a problem hiding this comment.
Duplicate of #23910?
I'll get my coat.
TimothyGu
approved these changes
Oct 29, 2018
Contributor
Author
|
@bnoordhuis oops. Would you rather land 4e10934? |
Member
|
Don't worry, it's fine. :-) |
3 tasks
Contributor
Author
mmarchini
approved these changes
Oct 29, 2018
Member
|
Landed in 93335cb |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 30, 2018
The warning is:
../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
^
../src/aliased_buffer.h:41:15: note: used here
buffer_ = Calloc<NativeT>(count);
PR-URL: #23954
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Member
@joyeecheung Did ncu let this through? It's been open < 48 hours and wasn't fast tracked either. (Just to be clear, I have no issue with the change itself, just the process.) |
Member
|
@richardlau oops, my bad, I ignored the warning because I assumed this was fast-tracked |
refack
added a commit
to refack/node
that referenced
this pull request
Oct 31, 2018
PR-URL: nodejs#23961 Refs: nodejs#23954 Refs: nodejs#23910 Refs: nodejs#23880 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Member
|
Depends on #23808 to land on v11.x-staging |
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
The warning is:
../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
^
../src/aliased_buffer.h:41:15: note: used here
buffer_ = Calloc<NativeT>(count);
PR-URL: #23954
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
The warning is:
../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
^
../src/aliased_buffer.h:41:15: note: used here
buffer_ = Calloc<NativeT>(count);
PR-URL: #23954
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
This was referenced Dec 7, 2018
Member
|
Adding the above label as patch application reports: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning is:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes