http2: compat support for nested array headers#24665
Closed
sebdeckers wants to merge 1 commit intonodejs:masterfrom
Closed
http2: compat support for nested array headers#24665sebdeckers wants to merge 1 commit intonodejs:masterfrom
sebdeckers wants to merge 1 commit intonodejs:masterfrom
Conversation
writeHead supports an array of arrays containing header name and values. Compatibility between http2 & http1 even though this is not documented. Fixes: nodejs#24466
Collaborator
|
@sebdeckers sadly an error occured when I tried to trigger a build :( |
jasnell
approved these changes
Nov 27, 2018
leeight
reviewed
Nov 27, 2018
leeight
reviewed
Nov 27, 2018
addaleax
approved these changes
Nov 27, 2018
fhinkel
approved these changes
Nov 27, 2018
cjihrig
approved these changes
Nov 27, 2018
lpinca
approved these changes
Nov 27, 2018
Member
Contributor
Author
|
@Trott What does that CI failure mean? I don't see how it relates to the patch. |
Member
|
That's likely an unrelated flaky failure but we can run again to verify |
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19053/ |
Member
|
Once more but with feeling: https://ci.nodejs.org/job/node-test-pull-request/19061/ |
Member
|
Landed in 5dacbf5 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 29, 2018
writeHead supports an array of arrays containing header name and values. Compatibility between http2 & http1 even though this is not documented. Fixes: nodejs#24466 PR-URL: nodejs#24665 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 29, 2018
writeHead supports an array of arrays containing header name and values. Compatibility between http2 & http1 even though this is not documented. Fixes: #24466 PR-URL: #24665 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
Author
|
Thanks for the help, @Trott and everyone who reviewed/commented. 🙇🏻♂️ |
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
writeHead supports an array of arrays containing header name and values. Compatibility between http2 & http1 even though this is not documented. Fixes: nodejs#24466 PR-URL: nodejs#24665 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
writeHead supports an array of arrays containing header name and values. Compatibility between http2 & http1 even though this is not documented. Fixes: #24466 PR-URL: #24665 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
writeHead supports an array of arrays containing header name and values. Compatibility between http2 & http1 even though this is not documented. Fixes: #24466 PR-URL: #24665 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes