test: from functools import reduce in test/testpy/__init__.py#24954
Closed
cclauss wants to merge 1 commit intonodejs:masterfrom
Closed
test: from functools import reduce in test/testpy/__init__.py#24954cclauss wants to merge 1 commit intonodejs:masterfrom
cclauss wants to merge 1 commit intonodejs:masterfrom
Conversation
$ __make lint-py__ # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], ""))
^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], "") + ".js")
^
2 F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```
richardlau
approved these changes
Dec 11, 2018
Trott
approved these changes
Dec 11, 2018
Member
BridgeAR
approved these changes
Dec 12, 2018
addaleax
approved these changes
Dec 12, 2018
Member
Member
|
I think the ARM issue might require q Rebuild instead of a Resume? CI: https://ci.nodejs.org/job/node-test-pull-request/19453/ ✔️ |
Member
|
Landed in 7ee61fb |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 14, 2018
$ __make lint-py__ # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], ""))
^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], "") + ".js")
^
2 F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```
PR-URL: nodejs#24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Dec 14, 2018
BethGriggs
pushed a commit
that referenced
this pull request
Dec 17, 2018
$ __make lint-py__ # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], ""))
^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], "") + ".js")
^
2 F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```
PR-URL: #24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
$ __make lint-py__ # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], ""))
^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], "") + ".js")
^
2 F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```
PR-URL: nodejs#24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
$ __make lint-py__ # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], ""))
^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], "") + ".js")
^
2 F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```
PR-URL: #24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
$ __make lint-py__ # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], ""))
^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], "") + ".js")
^
2 F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```
PR-URL: #24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
$ __make lint-py__ # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], ""))
^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
file_path = join(self.root, reduce(join, test[1:], "") + ".js")
^
2 F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```
PR-URL: #24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23659 !!!
$ make lint-py # When run on Python 3
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes