src: mark some global state as const#25052
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
cjihrig
approved these changes
Dec 14, 2018
Mark some global variables as `const` or `constexpr`.
Member
Author
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19551/ |
joyeecheung
approved these changes
Dec 15, 2018
Member
|
Windows CI failures related? |
joyeecheung
reviewed
Dec 15, 2018
jasnell
approved these changes
Dec 15, 2018
Member
Author
Member
|
One red CI failure on AIX is not something I've seen before, or not seen much of anyway, but it looks like it's caused by the same thing as the other child-process failures in tests. Opened #25068 to track it but in the meantime: Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19567/ |
Member
|
New failure is not seen before recently and appears to be caused by the same bug as other recent CI failures. Opened an issue for it: #25070 Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19571/ ✔️ |
joyeecheung
approved these changes
Dec 16, 2018
Member
|
Landed in 18f2bf7 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 17, 2018
Mark some global variables as `const` or `constexpr`. PR-URL: nodejs#25052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 25, 2018
Mark some global variables as `const` or `constexpr`. PR-URL: #25052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Mark some global variables as `const` or `constexpr`. PR-URL: nodejs#25052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark some global variables as
constorconstexpr.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes