http: make timeout event work with agent timeout#25488
Closed
lpinca wants to merge 1 commit intonodejs:masterfrom
Closed
http: make timeout event work with agent timeout#25488lpinca wants to merge 1 commit intonodejs:masterfrom
lpinca wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
|
@lpinca sadly an error occured when I tried to trigger a build :( |
f4f3182 to
07a6300
Compare
Member
Author
This was referenced Jan 16, 2019
The `'timeout'` event is currently not emitted on the `ClientRequest` instance when the socket timeout expires if only the `timeout` option of the agent is set. This happens because, under these circumstances, `listenSocketTimeout()` is not called. This commit fixes the issue by calling it also when only the agent `timeout` option is set.
07a6300 to
772c28b
Compare
Member
Author
|
cc: @nodejs/http |
addaleax
approved these changes
Jan 28, 2019
Member
|
@lpinca Do you want to merge this? |
Member
Author
|
@addaleax let's wait a little more for another approval, it's not a critical issue. We can merge this in a couple of days if nothing changed. Thank you. |
jasnell
approved these changes
Jan 29, 2019
Member
Author
|
Landed in 4b6e4c1. |
lpinca
added a commit
that referenced
this pull request
Jan 31, 2019
The `'timeout'` event is currently not emitted on the `ClientRequest` instance when the socket timeout expires if only the `timeout` option of the agent is set. This happens because, under these circumstances, `listenSocketTimeout()` is not called. This commit fixes the issue by calling it also when only the agent `timeout` option is set. PR-URL: #25488 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
The test added in this PR fails on my computer: |
Member
Author
|
Ok, I will change it to prevent it from using a non routable IP address so it will not be flaky. I'll get to it as soon as I can. |
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Jan 31, 2019
Fix flakyness caused by usage of a non-routable IP address. Refs: nodejs#25488 (comment)
4 tasks
addaleax
pushed a commit
that referenced
this pull request
Feb 1, 2019
The `'timeout'` event is currently not emitted on the `ClientRequest` instance when the socket timeout expires if only the `timeout` option of the agent is set. This happens because, under these circumstances, `listenSocketTimeout()` is not called. This commit fixes the issue by calling it also when only the agent `timeout` option is set. PR-URL: #25488 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Feb 2, 2019
Fix flakyness caused by usage of a non-routable IP address. Refs: nodejs#25488 (comment) PR-URL: nodejs#25854 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 3, 2019
Fix flakyness caused by usage of a non-routable IP address. Refs: #25488 (comment) PR-URL: #25854 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This was referenced Feb 15, 2019
This was referenced Feb 15, 2019
This was referenced Aug 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
'timeout'event is currently not emitted on theClientRequestinstance when the socket timeout expires if only the
timeoutoptionof the agent is set. This happens because, under these circumstances,
listenSocketTimeout()is not called.This commit fixes the issue by calling it also when only the agent
timeoutoption is set.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes