src: remove unused AsyncResource constructor in node.h#25793
Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove unused AsyncResource constructor in node.h#25793gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
Signed-off-by: gengjiawen <technicalcute@gmail.com>
jasnell
approved these changes
Jan 29, 2019
JungMinu
approved these changes
Jan 30, 2019
Contributor
Member
|
Landed in dee9a61 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Feb 1, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25793 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 3, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25793 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AsyncResource has two constructors. The removed constructor is not used anymore. Also the other constructor can easily replace the removed one.
The diff is one used
const char* name, the removed one usev8::Local<v8::String> name.make -j4 test(UNIX), orvcbuild test(Windows) passes