Skip to content

deps: upgrade npm to 6.7.0#25804

Closed
zkat wants to merge 1 commit intonodejs:masterfrom
npm:npm-6.7.0
Closed

deps: upgrade npm to 6.7.0#25804
zkat wants to merge 1 commit intonodejs:masterfrom
npm:npm-6.7.0

Conversation

@zkat
Copy link
Contributor

@zkat zkat commented Jan 29, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Where this should land
  • Node 11
  • Node 10
  • Node 8
Notable Changes

This PR supersedes #25551 and includes two releases. This is a significant change because it includes a major rework of the networking layer of npm and a rewrite of many subcommands. This, for example, removes npm-registry-client entirely in favor of npm-registry-fetch and libnpm. We've had to fix a couple of regressions since 6.6.0 came out, and we expect a few others to pop up, but nothing of huge impact has popped up, and they tend to be minor hiccups.

Other changes of note:

  • 02c837e01 #106 Make npm dist-tags the same as npm dist-tag ls. (@isaacs)

  • 1065a7809 #65 Add support for IBM i. (@dmabupt)

  • 8543fc357 pacote@9.4.0: Fall back to "fullfat" packuments on ETARGET errors. This will make it so that, when a package is published but the corgi follower hasn't caught up, users can still install a freshly-published package. (@zkat)

  • Another reminder that we've moved our issue tracking! You can read more about our move away from GitHub for issue tracking on our blog

Changelogs

/cc @MylesBorins

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Jan 29, 2019
@MylesBorins
Copy link
Contributor

MylesBorins commented Jan 29, 2019 •
edited
Loading

It appears v6.7.0 was published 6 days ago meaning that this would be good to land on Feb 6th

@zkat do you think we should give this a bit longer to wait before landing on LTS? For the record we have semver-minor releases for 8.x and 10.x planned for mid / late march, perhaps that would be a good timeline?

@MylesBorins MylesBorins self-requested a review January 29, 2019 23:12
@MylesBorins MylesBorins self-assigned this Jan 29, 2019
@richardlau richardlau mentioned this pull request Jan 29, 2019
Closed
4 tasks
@zkat
Copy link
Contributor Author

zkat commented Jan 30, 2019

I'd rather get this merged sooner tbh.

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 10, 2019 •
edited
Loading

It looks to me that 6.7.0 was published 3 days again. That's what I'm seeing on npmjs.org @zkat does that sounds right? If so then we can land this Feb 21st. I could have sworn it was already published when I checked last, so come clarity here would be appreciated.

It seems that the r.c. for 6.8.0 is what was published 3 days ago. This is ready to land after test suite is run

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 10, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20716/

edit: arm failure unrelated, rerunning for posterity

https://ci.nodejs.org/job/node-test-commit-arm-fanned/6399/

MylesBorins
MylesBorins approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 11, 2019 •
edited
Loading

Here is an output of running npx license-checker --summary

├─ MIT: 242
├─ ISC: 106
├─ BSD-2-Clause: 11
├─ Apache-2.0: 8
├─ BSD-3-Clause: 4
├─ Artistic-2.0: 4
├─ (WTFPL OR MIT): 3
├─ AFLv2.1,BSD: 1
├─ (MIT OR Apache-2.0): 1
├─ MIT*: 1
├─ Apache 2.0: 1
├─ (BSD-2-Clause OR MIT OR Apache-2.0): 1
├─ (BSD-2-Clause OR MIT): 1
├─ CC-BY-3.0: 1
├─ CC0-1.0: 1
└─ Unlicense: 1

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 12, 2019

landed in 43dd49c

MylesBorins pushed a commit that referenced this pull request Feb 12, 2019
@zkat @MylesBorins
deps: upgrade npm to 6.7.0
43dd49c 
PR-URL: #25804
Reviewed-By: Myles Borins <myles.borins@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 13, 2019
@zkat @addaleax
deps: upgrade npm to 6.7.0
1c5fbea 
PR-URL: #25804
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
@larsgw larsgw mentioned this pull request Feb 14, 2019
Closed
@beevelop beevelop mentioned this pull request Feb 15, 2019
Closed
tommyang added a commit to tommyang/homebrew-core that referenced this pull request Feb 15, 2019
@tommyang
node 11.10.0
b5e974e 
bump bundled npm to 6.7.0 nodejs/node#25804
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
lembacon pushed a commit to Homebrew/homebrew-core that referenced this pull request Feb 15, 2019
@tommyang @lembacon
node 11.10.0
fca1108 
bump bundled npm to 6.7.0 nodejs/node#25804

Closes #36995.

Signed-off-by: Chongyu Zhu <i@lembacon.com>
@beevelop beevelop mentioned this pull request Feb 15, 2019
Closed
@targos targos mentioned this pull request May 7, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@zkat @BethGriggs
deps: upgrade npm to 6.7.0
a385f2b 
PR-URL: #25804
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@zkat @MylesBorins
deps: upgrade npm to 6.7.0
d2413d6 
PR-URL: #25804
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
@wraithgar wraithgar deleted the npm-6.7.0 branch June 26, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MylesBorins MylesBorins MylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MylesBorins MylesBorins

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zkat @MylesBorins @nodejs-github-bot