src: only open HandleScope when necessary#26734
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: only open HandleScope when necessary#26734addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Mar 18, 2019
jasnell
approved these changes
Mar 18, 2019
apapirovski
approved these changes
Mar 19, 2019
danbev
approved these changes
Mar 21, 2019
Contributor
Member
Author
Member
Author
|
Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/21720/ |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 21, 2019
PR-URL: nodejs#26734 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Member
|
Landed in bca23f2 🎉 |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
PR-URL: nodejs#26734 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
PR-URL: #26734 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes