lib: make queueMicrotask faster#27032
Closed
apapirovski wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
Accessing symbols is generally quite expensive and so is emitInit, only do both when actually required.
No longer create an additional scope within queueMicrotask in order to improve performance.
Collaborator
BridgeAR
approved these changes
Mar 31, 2019
Collaborator
Collaborator
Contributor
|
Benchmark (job 313) results: |
Member
|
Don't forget to run |
Member
The test will continue to pass. |
This was referenced Apr 2, 2019
Collaborator
jasnell
approved these changes
Apr 4, 2019
Contributor
danbev
pushed a commit
that referenced
this pull request
Apr 5, 2019
Accessing symbols is generally quite expensive and so is emitInit, only do both when actually required. PR-URL: #27032 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
danbev
pushed a commit
that referenced
this pull request
Apr 5, 2019
No longer create an additional scope within queueMicrotask in order to improve performance. PR-URL: #27032 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async_hooks: improve
AsyncResourceperformanceAccessing properties behind a symbol is generally quite expensive and so is
emitInit, only do both when actually required.lib: make
queueMicrotaskfasterNo longer create an additional scope within
queueMicrotaskin order to improve performance.CI: https://ci.nodejs.org/job/node-test-pull-request/22078/
Benchmark CI: https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/313/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes