meta: travis: start slower jobs first#27205
Merged
refack merged 1 commit intonodejs:masterfrom Apr 15, 2019
Merged
Conversation
Collaborator
richardlau
approved these changes
Apr 12, 2019
Member
|
One thing I have noticed is that the way staging works if any of the first stage jobs fail (e.g. commit message lint or linter) then the second stage isn't run (i.e. no tests are run). On the one hand having the linting done in the first stage returns results quicker, but maybe we can move linting into the test stage so all linting and tests are attempted (assuming the code compiles)? |
Contributor
Author
So that |
richardlau
approved these changes
Apr 13, 2019
Member
richardlau
left a comment
There was a problem hiding this comment.
nit: when squashing please reword the first commit (something like "run compilation jobs first").
Trott
approved these changes
Apr 13, 2019
even though jobs can run in parallel they start in declaration order * this patch makes "compiles >> no lint" in terms of precedence PR-URL: nodejs#27205 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
aba17c6 to
f3b5cc0
Compare
Contributor
Author
|
Pre: 🤘 🎸 👨🎤 [Update] even better: |
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
even though jobs can run in parallel they start in declaration order
/CC @nodejs/build-files @nodejs/testing
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes