net: make writeAfterFIN() return false#27996
Closed
lpinca wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
If `false` is not returned a readable stream piped into the socket might continue reading indefinitely until the process goes out of memory.
Member
Author
'use strict';
const net = require('net');
const { Readable } = require('stream');
const chunk = Buffer.alloc(1024);
const readable = new Readable({
read() {
this.push(chunk);
}
});
const server = net.createServer(function(socket) {
server.close();
socket.resume();
setTimeout(function() {
socket.end();
}, 100);
});
server.listen(function() {
const socket = net.connect(this.address().port, function() {
socket.resume();
socket.on('error', function() {});
readable.pipe(socket);
});
}); |
addaleax
approved these changes
May 31, 2019
Member
|
Does the documentation for
|
Member
Author
|
@Trott I think it's not needed. When |
Trott
approved these changes
Jun 2, 2019
cjihrig
approved these changes
Jun 3, 2019
Collaborator
Contributor
|
Landed in 714a32c. |
danbev
pushed a commit
that referenced
this pull request
Jun 4, 2019
If `false` is not returned a readable stream piped into the socket might continue reading indefinitely until the process goes out of memory. PR-URL: #27996 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
If `false` is not returned a readable stream piped into the socket might continue reading indefinitely until the process goes out of memory. PR-URL: #27996 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
falseis not returned a readable stream piped into the socketmight continue reading indefinitely until the process goes out of
memory.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes