test,report: relax CPU match requirements#28884
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
test,report: relax CPU match requirements#28884addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Some CPUs have variable speeds, and so exact matches between what
`os.cpus()` and the report feature yield cannot always be expected:
```
> const results = []
> setInterval(() => results.push(os.cpus().map(({ speed }) => speed)), 1)
[...]
> results
[
[ 1198, 1150, 1195, 1149 ],
[ 1198, 1150, 1195, 1149 ],
[ 1198, 1150, 1195, 1149 ],
[ 1198, 1150, 1195, 1149 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2596, 2401, 2699, 2555 ],
[...]
```
Refs: nodejs#28829
devsnek
approved these changes
Jul 28, 2019
devsnek
approved these changes
Jul 28, 2019
richardlau
approved these changes
Jul 29, 2019
trivikr
approved these changes
Jul 29, 2019
2 tasks
Member
|
Should close #28886? |
ChALkeR
approved these changes
Jul 29, 2019
Contributor
|
👍 to fast track? |
jasnell
approved these changes
Jul 29, 2019
lpinca
approved these changes
Jul 29, 2019
Collaborator
Trott
approved these changes
Jul 29, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 29, 2019
Some CPUs have variable speeds, and so exact matches between what
`os.cpus()` and the report feature yield cannot always be expected:
```
>const results = []
>setInterval(() => results.push(os.cpus().map(({ speed }) => speed)), 1)
[...]
>results
[
[ 1198, 1150, 1195, 1149 ],
[ 1198, 1150, 1195, 1149 ],
[ 1198, 1150, 1195, 1149 ],
[ 1198, 1150, 1195, 1149 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2596, 2401, 2699, 2555 ],
[...]
```
Refs: nodejs#28829
PR-URL: nodejs#28884
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in 98d8ed6 |
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
Some CPUs have variable speeds, and so exact matches between what
`os.cpus()` and the report feature yield cannot always be expected:
```
>const results = []
>setInterval(() => results.push(os.cpus().map(({ speed }) => speed)), 1)
[...]
>results
[
[ 1198, 1150, 1195, 1149 ],
[ 1198, 1150, 1195, 1149 ],
[ 1198, 1150, 1195, 1149 ],
[ 1198, 1150, 1195, 1149 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2401, 2420, 2429, 2413 ],
[ 2596, 2401, 2699, 2555 ],
[...]
```
Refs: #28829
PR-URL: #28884
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some CPUs have variable speeds, and so exact matches between what
os.cpus()and the report feature yield cannot always be expected:Refs: #28829
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes