repl: add autocomplete support for fs.promises#29400
Closed
antsmartian wants to merge 1 commit intonodejs:masterfrom
Closed
repl: add autocomplete support for fs.promises#29400antsmartian wants to merge 1 commit intonodejs:masterfrom
antsmartian wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
Author
|
ping @nodejs/repl |
jasnell
approved these changes
Sep 3, 2019
Collaborator
Collaborator
Collaborator
Member
|
Removed |
addaleax
approved these changes
Sep 7, 2019
Member
addaleax
left a comment
There was a problem hiding this comment.
LGTM, I’m okay with fixing the nits while landing or separately
Contributor
Author
Collaborator
Collaborator
ZYSzys
approved these changes
Sep 15, 2019
Member
|
Landed in ed0e5c8 |
Trott
pushed a commit
that referenced
this pull request
Sep 16, 2019
PR-URL: #29400 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
PR-URL: #29400 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
PR-URL: #29400 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of this #26648. Adding support for
fs.promisesalso updated the test files.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes