src: fix ESM path resolution on Windows#29574
Closed
Hakerh400 wants to merge 1 commit intonodejs:masterfrom
Hakerh400:esm
Closed
src: fix ESM path resolution on Windows#29574Hakerh400 wants to merge 1 commit intonodejs:masterfrom Hakerh400:esm
Hakerh400 wants to merge 1 commit intonodejs:masterfrom
Hakerh400:esm
Conversation
Member
|
Can you add regression tests? |
Member
|
@nodejs/platform-windows @nodejs/modules-active-members |
guybedford
reviewed
Sep 16, 2019
Contributor
guybedford
left a comment
There was a problem hiding this comment.
TIL!
Thanks for the PR, it looks great to merge as-is, I've just commented on if there might be more cases to catch, but let me know if the case mentioned isn't actually an issue.
Windows has some reserved file names such as "con", "prn", "nul", etc. Such files can be accessed only if the path is prefixed with "\\.\"
guybedford
approved these changes
Sep 20, 2019
Collaborator
Member
|
@nodejs/collaborators This is good to land, but might benefit from another review, especially from someone who uses Windows. |
Collaborator
Collaborator
Collaborator
Member
|
Landed in 6265e41 |
Trott
pushed a commit
that referenced
this pull request
Oct 4, 2019
Windows has some reserved file names such as "con", "prn", "nul", etc. Such files can be accessed only if the path is prefixed with "\\.\" PR-URL: #29574 Reviewed-By: Guy Bedford <guybedford@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
Windows has some reserved file names such as "con", "prn", "nul", etc. Such files can be accessed only if the path is prefixed with "\\.\" PR-URL: #29574 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows has some reserved file names such as
con,prn,nul, etc. Such files can be accessed only if the path is prefixed with\\.\Fixes #29572
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes