Closed
Conversation
addaleax
approved these changes
Oct 14, 2019
Member
Author
|
I'd like to fast-track this to fix nightly CI. Please 👍 here to approve if you're a collaborator. Thanks! |
cjihrig
approved these changes
Oct 14, 2019
This comment has been minimized.
This comment has been minimized.
devnexen
approved these changes
Oct 14, 2019
Member
Author
|
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3991/ (benchmark tests are not run in regular CI) |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 14, 2019
Add missing option "mode". Alphabetize options for easier maintenance. PR-URL: nodejs#29967 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Member
Author
|
Landed in 7991b57 |
158968b to
7991b57
Compare
targos
pushed a commit
that referenced
this pull request
Nov 8, 2019
Add missing option "mode". Alphabetize options for easier maintenance. PR-URL: #29967 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
Add missing option "mode". Alphabetize options for easier maintenance. PR-URL: #29967 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing option "mode". Alphabetize options for easier maintenance.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes