lib,src: switch Buffer::kMaxLength to size_t#31406
Closed
bnoordhuis wants to merge 2 commits intonodejs:masterfrom
Closed
lib,src: switch Buffer::kMaxLength to size_t#31406bnoordhuis wants to merge 2 commits intonodejs:masterfrom
bnoordhuis wants to merge 2 commits intonodejs:masterfrom
Conversation
Change the type of `Buffer::kMaxLength` to size_t because upcoming changes in V8 will allow typed arrays > 2 GB on 64 bits platforms. Not all platforms handle file reads and writes > 2 GB though so keep enforcing the 2 GB typed array limit for I/O operations. Fixes: nodejs#31399 Refs: libuv/libuv#1501
richardlau
approved these changes
Jan 18, 2020
devnexen
approved these changes
Jan 18, 2020
cjihrig
approved these changes
Jan 18, 2020
lpinca
approved these changes
Jan 18, 2020
addaleax
approved these changes
Jan 18, 2020
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Jan 18, 2020
tniessen
approved these changes
Jan 19, 2020
codebytere
approved these changes
Jan 19, 2020
Contributor
|
I think you'll want to update this line as well: replace |
Member
Author
|
Good catch. Updated, thanks. |
This comment has been minimized.
This comment has been minimized.
Collaborator
Member
|
Landed in 5005c3c |
Trott
pushed a commit
that referenced
this pull request
Jan 21, 2020
Change the type of `Buffer::kMaxLength` to size_t because upcoming changes in V8 will allow typed arrays > 2 GB on 64 bits platforms. Not all platforms handle file reads and writes > 2 GB though so keep enforcing the 2 GB typed array limit for I/O operations. Fixes: #31399 Refs: libuv/libuv#1501 PR-URL: #31406 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
Change the type of `Buffer::kMaxLength` to size_t because upcoming changes in V8 will allow typed arrays > 2 GB on 64 bits platforms. Not all platforms handle file reads and writes > 2 GB though so keep enforcing the 2 GB typed array limit for I/O operations. Fixes: #31399 Refs: libuv/libuv#1501 PR-URL: #31406 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Merged
Member
|
@bnoordhuis is this a change that should go to |
Member
Author
|
@codebytere I've updated the labels. A back-port shouldn't be necessary unless v12.x updates to a new enough V8 version and this PR is technically a semver-major change. |
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 1, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 2, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 4, 2020
3 tasks
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Sep 9, 2020
nodejs#31406 introduced a regression in `Hash`, `Hmac`, `SignBase`, and `PublicKeyCipher` Signed-off-by: James M Snell <jasnell@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 14, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 14, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 14, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the type of
Buffer::kMaxLengthto size_t because upcomingchanges in V8 will allow typed arrays > 2 GB on 64 bits platforms.
Not all platforms handle file reads and writes > 2 GB though so keep
enforcing the 2 GB typed array limit for I/O operations.
Fixes: #31399
Refs: libuv/libuv#1501