Skip to content

test: fix test-heapdump-worker#31494

Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:pummel-heapdump-worker2
Closed

test: fix test-heapdump-worker#31494
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:pummel-heapdump-worker2

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Jan 24, 2020

This test was broken by de2c68c.

Refs: #31386

/cc @Trott

Also, this fix is almost identical to ed60e86 … maybe we should have at least one platform/job running the full test suite in CI?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: fix test-heapdump-worker
3f15e30 
This test was broken by de2c68c.

Refs: nodejs#31386
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 24, 2020
@addaleax addaleax added the fast-track PRs that do not need to wait for 72 hours to land. label Jan 24, 2020
@addaleax
Copy link
Member Author

addaleax commented Jan 24, 2020

👍 this comment to approve fast-tracking

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28606/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28608/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28611/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28614/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 25, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28648/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 25, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28653/

@Trott
Copy link
Member

Trott commented Jan 25, 2020

Landed in 278d37d

@Trott Trott closed this Jan 25, 2020
Trott pushed a commit that referenced this pull request Jan 25, 2020
@addaleax @Trott
test: fix test-heapdump-worker
278d37d 
This test was broken by de2c68c.

Refs: #31386

PR-URL: #31494
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@addaleax @codebytere
test: fix test-heapdump-worker
f2dc694 
This test was broken by de2c68c.

Refs: #31386

PR-URL: #31494
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@addaleax @codebytere
test: fix test-heapdump-worker
31e1af6 
This test was broken by de2c68c.

Refs: #31386

PR-URL: #31494
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax deleted the pummel-heapdump-worker2 branch March 16, 2020 11:29
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@addaleax @codebytere
test: fix test-heapdump-worker
e3e056d 
This test was broken by de2c68c.

Refs: #31386

PR-URL: #31494
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 72 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax @nodejs-github-bot @Trott @cjihrig @devnexen @richardlau